From cc7ead6059e7d6e80441efde6ab04c2a2f1419ee Mon Sep 17 00:00:00 2001 From: Pedro Rey Anca Date: Thu, 5 Dec 2024 17:02:56 +0100 Subject: [PATCH] Don't leak suggester data --- web/lazaro_quotes/models.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/web/lazaro_quotes/models.py b/web/lazaro_quotes/models.py index c7bb352..75e2cc9 100644 --- a/web/lazaro_quotes/models.py +++ b/web/lazaro_quotes/models.py @@ -28,11 +28,12 @@ class Quote(models.Model): def __str__(self): return self.text - def as_dict(self): + def as_dict(self, suggester=False): result = model_to_dict(self, fields=["text"]) result["author"] = model_to_dict(self.author, exclude=["id"]) - result["suggester"] = model_to_dict( - self.suggester, exclude=["id"]) if self.suggester else None + if suggester: + result["suggester"] = model_to_dict( + self.suggester, exclude=["id"]) if self.suggester else None return result